Skip to content

Commit

Permalink
Merge pull request #10904 from yuzeming/fixed-10899
Browse files Browse the repository at this point in the history
integration: fix a data race about `i` and `tt` in TestV3WatchFromCur…
  • Loading branch information
jingyih authored Jul 20, 2019
2 parents 39680c3 + 5f21b55 commit fe86a78
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions integration/v3_watch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ func TestV3WatchFromCurrentRevision(t *testing.T) {
}

// asynchronously create keys
ch := make(chan struct{}, 1)
go func() {
for _, k := range tt.putKeys {
kvc := toGRPC(clus.RandClient()).KV
Expand All @@ -253,6 +254,7 @@ func TestV3WatchFromCurrentRevision(t *testing.T) {
t.Errorf("#%d: couldn't put key (%v)", i, err)
}
}
ch <- struct{}{}
}()

// check stream results
Expand Down Expand Up @@ -286,6 +288,9 @@ func TestV3WatchFromCurrentRevision(t *testing.T) {
t.Errorf("unexpected pb.WatchResponse is received %+v", nr)
}

// wait for the client to finish sending the keys before terminating the cluster
<-ch

// can't defer because tcp ports will be in use
clus.Terminate(t)
}
Expand Down

0 comments on commit fe86a78

Please sign in to comment.