Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make equivalent of /livez and /readyz in gRPC and etcdctl command #17925

Open
henrybear327 opened this issue May 2, 2024 · 3 comments
Open

Make equivalent of /livez and /readyz in gRPC and etcdctl command #17925

henrybear327 opened this issue May 2, 2024 · 3 comments
Assignees
@henrybear327
Labels
area/etcdctl priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature

Comments

@henrybear327
Copy link
Contributor

henrybear327 commented May 2, 2024 •
edited
Loading

What would you like to be added?

As discussed and mentioned in the comment, take this commit as a base, and finish the implementation of livez/readyz in gRPC and etcdctl command.

Why is this needed?

Based on the discussions in #16007
@henrybear327
Copy link
Contributor Author

/cc @siyuanfoundation
/assign @henrybear327

@henrybear327 henrybear327 changed the title Make equivalent of /livez and /readyz in GRPC Make equivalent of /livez and /readyz in gRPC and etcdctl command May 2, 2024
@jmhbnz jmhbnz added area/etcdctl priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 2, 2024
@serathius
Copy link
Member

Please note #16007 (comment)

Due to #15402 we are supporting a separating HTTP and GRPC endpoints, and recommend it for production.

@henrybear327
Copy link
Contributor Author

Please note #16007 (comment)

Due to #15402 we are supporting a separating HTTP and GRPC endpoints, and recommend it for production.

Looks like the HTTP part is completed. I will focus on the gRPC part, and extend the feature to the etcdctl command for now!

henrybear327 added a commit to henrybear327/etcd that referenced this issue May 15, 2024
@henrybear327 @siyuanfoundation
Make equivalent of /livez and /readyz in gRPC and etcdctl command
97eabf4 
Reference:
- etcd-io#17925
- etcd-io@293f087#diff-ab6fb0684315e16355f6ebe0f4b3cf860b9b2ff5a0fe1b4e4308a680b19f1b0c

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Co-authored-by: Siyuan Zhang <sizhang@google.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue May 18, 2024
@henrybear327 @siyuanfoundation
Make equivalent of /livez and /readyz in gRPC and etcdctl command
eaf9561 
Reference:
- etcd-io#17925
- etcd-io@293f087#diff-ab6fb0684315e16355f6ebe0f4b3cf860b9b2ff5a0fe1b4e4308a680b19f1b0c

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Co-authored-by: Siyuan Zhang <sizhang@google.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue May 21, 2024
@henrybear327 @siyuanfoundation
Make equivalent of /livez and /readyz in gRPC and etcdctl command
4bc5d15 
Reference:
- etcd-io#17925
- etcd-io@293f087#diff-ab6fb0684315e16355f6ebe0f4b3cf860b9b2ff5a0fe1b4e4308a680b19f1b0c

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Co-authored-by: Siyuan Zhang <sizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrybear327 henrybear327

Labels
area/etcdctl priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serathius @henrybear327 @jmhbnz