Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: cherry pick of #9990 to release 3.1 #10030

Merged
merged 2 commits into from
Aug 20, 2018
Merged

etcdserver: cherry pick of #9990 to release 3.1 #10030

merged 2 commits into from
Aug 20, 2018

Commits on Aug 20, 2018

  1. etcdserver: add grpc interceptor to log info on incoming request to e… 

    …tcdserver.

To improve debuggability of etcd v3. Added a grpc interceptor to log
info on incoming requests to etcd server. The log output includes remote
client info, request content (with value field redacted), request
handling latency, response size, etc.

Dependency on zap logger and grpc_middleware is removed during
backporting.

Added checking in logging interceptor. If debug level is disabled, skip
logUnaryRequestStats() to avoid potential performance degradation. (PR etcd-io#10021)
    Jingyi Hu committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    4855ca6 View commit details
    Browse the repository at this point in the history

  2. etcdserver: add grpc interceptor to log info on incoming request to 

    etcdserver

To improve debuggability of etcd v3.1. Added a grpc interceptor to log
info on incoming requests to etcd server. The log output includes remote
client info, request content (with value field redacted), request
handling latency, response size, etc.

Dependency on zap logger and grpc_middleware is removed during
backporting.

Added checking in logging interceptor. If debug level is disabled, skip
logUnaryRequestStats() to avoid potential performance degradation. (PR etcd-io#10021)
    Jingyi Hu committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    dd2803c View commit details
    Browse the repository at this point in the history