[WIP] *: Fully concurrent large reads #10472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvcc: add metrics to characterize backend expensive reads
*: add flag for backend expensive read limit
mvcc: Limit number of bbolt read transactions opened by committed reads
Codecov Report
@@ Coverage Diff @@
## master #10472 +/- ##
==========================================
- Coverage 71.67% 63.51% -8.17%
==========================================
Files 392 392
Lines 36495 36546 +51
==========================================
- Hits 26158 23212 -2946
- Misses 8517 11387 +2870
- Partials 1820 1947 +127
Continue to review full report at Codecov.
|
hexfusion
reviewed
Feb 14, 2019
| rtx, err := r.b.db.Begin(false) | ||
| if err != nil { | ||
| plog.Fatalf("cannot begin read tx (%s)", err) | ||
| } |
There was a problem hiding this comment.
Do we want to also add zap here capnslog will be dropped in 3.4
There was a problem hiding this comment.
Good catch, I'll add it.
| func (rt *concurrentReadTx) UnsafeRange(bucketName, key, endKey []byte, limit int64) ([][]byte, [][]byte) { | ||
| bucket := rt.tx.Bucket(bucketName) | ||
| if bucket == nil { | ||
| plog.Fatalf("bucket %s does not exist", bucketName) |
|
See #10523 for current efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP continuation of #9384.