raft: leader respond to learner read index message #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case, does the leader need to check if it has committed any log entry at the current term? |
Codecov Report
@@ Coverage Diff @@
## master #10590 +/- ##
==========================================
- Coverage 71.6% 71.49% -0.11%
==========================================
Files 393 393
Lines 36568 36571 +3
==========================================
- Hits 26183 26146 -37
- Misses 8549 8588 +39
- Partials 1836 1837 +1
Continue to review full report at Codecov.
|
jingyih
changed the title
xiang90
reviewed
Mar 28, 2019
|
lgtm |
Leader should check message sender after receiving MsgReadIndex, even when raft quorum is 1. The message could be sent from learner node, and leader should respond.
jingyih
force-pushed
the
fix_readIndex_for_learner
branch
from
60224f3
to
5088d70
Compare
xiang90
reviewed
Mar 28, 2019
| } else { // there is only one voting member (the leader) in the cluster | ||
| if m.From == None || m.From == r.id { // from leader itself | ||
| r.readStates = append(r.readStates, ReadState{Index: r.raftLog.committed, RequestCtx: m.Entries[0].Data}) | ||
| } else { // from learner member |
There was a problem hiding this comment.
i just hit the merge button... but actually you can check if m.From is indeed a learner for extra safety.
There was a problem hiding this comment.
Since here we have r.quorum()==1, which means r.prs only has leader itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leader should check message sender upon receiving MsgReadIndex message, even when raft quorum is 1. The message could be sent from learner node. In this case, leader should respond to the sender.
Fixes #10589.
cc @xiang90 @gyuho @WIZARD-CXY @jpbetz