-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update gRPC Go to v1.26.0 #11522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11522 +/- ##
==========================================
+ Coverage 64.39% 64.44% +0.05%
==========================================
Files 403 403
Lines 38088 38088
==========================================
+ Hits 24525 24547 +22
+ Misses 11924 11901 -23
- Partials 1639 1640 +1
Continue to review full report at Codecov.
|
lgtm |
1 similar comment
lgtm |
@YoyinZyc change log needs to be updated. |
@@ -25,83 +25,37 @@ import ( | |||
"google.golang.org/grpc/balancer" | |||
"google.golang.org/grpc/connectivity" | |||
"google.golang.org/grpc/grpclog" | |||
"google.golang.org/grpc/internal/buffer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YoyinZyc hi, I was looking at the couple of issue #11532 and #11529
and I think that these issues are might be because of https://github.com/etcd-io/etcd/tree/master/vendor/google.golang.org/grpc/internal doesn't have the referenced internal/buffer
package. The https://github.com/grpc/grpc-go/tree/master/internal has it there. I haven't worked on updating etcd vendor files before but I believe having vendor dir updated with grpc-go master buffer should fix it. Please let me know what you think? Thanks!
"google.golang.org/grpc/serviceconfig" | ||
"google.golang.org/grpc/status" | ||
|
||
_ "google.golang.org/grpc/balancer/roundrobin" // To register roundrobin. | ||
_ "google.golang.org/grpc/internal/resolver/dns" // To register dns resolver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YoyinZyc similar to my above comment - while looking at the couple of issues #11532 and #11529
, I think that these issues are might be because of https://github.com/etcd-io/etcd/tree/master/vendor/google.golang.org/grpc/internal doesn't have the referenced internal/resolver
package. The https://github.com/grpc/grpc-go/tree/master/internal has it there. I haven't worked on updating etcd vendor files before but I believe having vendor dir updated with these packages should fix it. Please let me know what you think? Thanks!
* clientv3: fix grpc-go(v1.27.0) incompatible changes to balancer/resolver. * vendor: upgrade gRPC Go to v1.24.0 Picking up some performance improvements and bug fixes. https://github.com/grpc/grpc-go/releases/tag/v1.24.0 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> * vendor: update gRPC Go to v1.26.0 (#11522) * GO111MODULE=on go mod vendor * GO111MODULE=on go mod vendor go 1.14 Bump travis 2 Co-authored-by: EDDYCJY <313687982@qq.com> Co-authored-by: Gyuho Lee <leegyuho@amazon.com> Co-authored-by: Yuchen Zhou <yczhou@google.com>
for #11519