Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Added s390x support for docker image release #11548

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

nirmannarang
Copy link
Contributor

Dockerfile-release.s390x: Added dockerfile for s390x
etcdmain/etcd.go: Added GOARCH for s390x for supported archs
scripts/build-release.sh: Added TARGET_ARCH for s390x
scripts/release: Added TARGET_ARCH for s390x

@codecov-io
Copy link

Codecov Report

Merging #11548 into master will decrease coverage by 0.81%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11548      +/-   ##
==========================================
- Coverage   64.72%    63.9%   -0.82%     
==========================================
  Files         403      403              
  Lines       38097    38097              
==========================================
- Hits        24657    24347     -310     
- Misses      11801    12116     +315     
+ Partials     1639     1634       -5
Impacted Files Coverage Δ
etcdmain/etcd.go 0% <0%> (ø) ⬆️
client/client.go 58.49% <0%> (-25.5%) ⬇️
auth/store.go 47.95% <0%> (-20.67%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0%> (-16.13%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
etcdserver/api/v3rpc/lease.go 69.31% <0%> (-5.69%) ⬇️
clientv3/concurrency/mutex.go 62.16% <0%> (-5.41%) ⬇️
clientv3/leasing/cache.go 87.22% <0%> (-4.45%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00e929...17a220e. Read the comment docs.

@gyuho
Copy link
Contributor

gyuho commented Feb 6, 2020

@nirmannarang Thanks for the contribution. Could you also create another PR to highlight this in CHANGELOG? https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.5.md

@gyuho gyuho merged commit aea3354 into etcd-io:master Feb 6, 2020
nirmannarang added a commit to linux-on-ibm-z/etcd that referenced this pull request Apr 13, 2020
Signed-off-by: Nirman Narang <narang@us.ibm.com>
spzala added a commit that referenced this pull request Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants