Upgrade to google.golang.org/grpc@1.35.0
#12636
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package grpcnaming | ||
|
There was a problem hiding this comment. |
||
|
|
||
| // Operation defines the corresponding operations for a name resolution change. | ||
| type Operation uint8 | ||
|
|
||
| const ( | ||
| // Add indicates a new address is added. | ||
| Add Operation = iota | ||
| // Delete indicates an existing address is deleted. | ||
| Delete | ||
| ) | ||
|
|
||
| // Update defines a name resolution update. Notice that it is not valid having both | ||
| // empty string Addr and nil Metadata in an Update. | ||
| type Update struct { | ||
| // Op indicates the operation of the update. | ||
| Op Operation | ||
| // Addr is the updated address. It is empty string if there is no address update. | ||
| Addr string | ||
| // Metadata is the updated metadata. It is nil if there is no metadata update. | ||
| // Metadata is not required for a custom naming implementation. | ||
| Metadata interface{} | ||
| } | ||
|
|
||
| // Watcher watches for the updates on the specified target. | ||
| type Watcher interface { | ||
| // Next blocks until an update or error happens. It may return one or more | ||
| // updates. The first call should get the full set of the results. It should | ||
| // return an error if and only if Watcher cannot recover. | ||
| Next() ([]*Update, error) | ||
| // Close closes the Watcher. | ||
| Close() | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. here:
etcd/client/v3/balancer/balancer.go
Line 145 in 5dcd459
My goal here was to avoid a big diff in
.gosource files to make it easier for maintainers to grok what has changed. Notice thatHandleResolvedAddrs()is no longer part of theBalancerinterface:So we could just rename
HandleResolvedAddrs()toUpdateClientConnState()and justreturn errafter some / all of thebb.lg.Warn()statements.