Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of dependencies in go.mod: zap, bbolt, grpc, ... #13078

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Update of dependencies in go.mod: zap, bbolt, grpc, ... #13078

merged 4 commits into from
Jun 3, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Jun 3, 2021 •
edited
Loading 

  - go.uber.org/zap@v1.17.0
  - bbolt-1.3.6
  - grpc -1.38
  - github.com/coreos/go-systemd/v22 v22.3.2
  - github.com/google/btree v1.0.1
  - github.com/json-iterator/go v1.1.11
  - github.com/mattn/go-runewidth v0.0.13
  - github.com/prometheus/client_golang v1.10.0
  - github.com/sirupsen/logrus v1.8.1

ptabor added 3 commits June 3, 2021 12:37
@ptabor
Update zap to v1.17.0.
90cea7d
@ptabor
Update bbolt to v1.3.6.
b240625 
`./scripts/update_dep.sh go.etcd.io/bbolt v1.3.6`
@ptabor
Update dependencies:
edcfe57 
  - github.com/coreos/go-systemd/v22 v22.3.2
  - github.com/google/btree v1.0.1
  - github.com/json-iterator/go v1.1.11
  - github.com/mattn/go-runewidth v0.0.13
  - github.com/prometheus/client_golang v1.10.0
  - github.com/prometheus/common v0.26.0
  - github.com/sirupsen/logrus v1.8.1
@ptabor ptabor changed the title Update of dependencies in go.mod Update of dependencies in go.mod: zap, bbolt, grpc, ... Jun 3, 2021
@ptabor ptabor force-pushed the 20210604-modules-main branch from bcb34af to 994c3b7 Compare June 3, 2021 13:21
lilic
lilic reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

server/go.mod Outdated
replace go.etcd.io/tests/v3 => ./FORBIDDEN_DEPENDENCY

// Avoid dependency on go.etcd.io/etcd.
replace github.com/go-kit/kit v0.10.0 => github.com/go-kit/kit v0.10.1-0.20210530035833-3b053a73c0f4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this? I thought it was solved by todays prometheus/common release? Or does it not come from client_golang?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from prometheus/client_golang
I might try to depend on prometheus/client_golang@2539062 instead.

Copy link
Contributor

@lilic lilic Jun 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that was not released yet, makes sense. @kakkoyun is there any plans to maybe release a patch release of client_golang? Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. As in both scenarios we depend on unstable version, I found depending on ustable prometheus/client_golang cleaner. PTAL.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No plans yet for a need patch release. I'd advise to use a master version 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that for release-3.5 we need to stick to last stable version that does not introduce a cyclic dependency, i.e:
github.com/prometheus/client_golang v1.5.1 (

etcd/client/v3/go.mod

Line 8 in fea5ace

github.com/prometheus/client_golang v1.5.1
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how the k8s deps would play with that?

@ptabor ptabor mentioned this pull request Jun 3, 2021
Closed
4 tasks
@ptabor ptabor force-pushed the 20210604-modules-main branch from 994c3b7 to aa8fd50 Compare June 3, 2021 14:05
@ptabor
Upgrade of prometheous deps.
404efd7 
For now we need to depend on unstable: prometheus/client_golang
@ptabor ptabor force-pushed the 20210604-modules-main branch from aa8fd50 to 404efd7 Compare June 3, 2021 14:07
lilic
lilic approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ptabor ptabor merged commit e32e91c into etcd-io:main Jun 3, 2021
@ptabor ptabor deleted the 20210604-modules-main branch June 3, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@kakkoyun kakkoyun kakkoyun left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptabor @kakkoyun @lilic