-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/etcdserver/api/etcdhttp: exclude the same alarm type activated by multiple peers #13467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by multiple peers
hexfusion
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
please update changelogs for backports thanks! |
spzala
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks!
chaochn47
added a commit
to chaochn47/etcd
that referenced
this pull request
Nov 12, 2021
…multiple peers
This was referenced Nov 12, 2021
Updated the change log with the backport PRs. PTAL thanks!! |
hexfusion
added a commit
that referenced
this pull request
Nov 14, 2021
cherry-pick to 3.5 from #13467 exclude the same alarm type activated by multiple peers
hexfusion
added a commit
that referenced
this pull request
Nov 14, 2021
backport 3.4 from #13467 exclude the same alarm type activated by multiple peers
hasbro17
pushed a commit
to hasbro17/etcd
that referenced
this pull request
Feb 2, 2022
cherry-pick to 3.5 from etcd-io#13467 exclude the same alarm type activated by multiple peers
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 8, 2022
…multiple peers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12880 failed to exclude all alarms activated by multiple members for a given alarm type.
Reproduce
etcd version
3.4.17
After this PR
PTAL @hexfusion @gyuho