Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR 13308 to release-3.5 #13477

Merged
merged 2 commits into from
Nov 21, 2021

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Nov 14, 2021

This PR backports #13308 and a related commit to release-3.5.

Could you take a look @hexfusion ?

r-ashish and others added 2 commits November 15, 2021 00:09
…ying

To fix a bug in the retry logic caused when the auth token is cleared after receiving `ErrInvalidAuthToken` from the server and the subsequent call to `getToken` also fails due to some reason (eg. context deadline exceeded).
This leaves the client without a token and the retry will continue to fail with `ErrUserEmpty` unless the token is refreshed.
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitake looks good would you mind bumping the 3.5 CHANGELOG, please.

@mitake
Copy link
Contributor Author

mitake commented Nov 21, 2021

@hexfusion got it, I opened a different PR for updating CHANGELOG-3.5 in the main branch: #13492 is this ok for bumping the changelog?

@hexfusion hexfusion merged commit eac7f98 into etcd-io:release-3.5 Nov 21, 2021
@serathius serathius mentioned this pull request Dec 6, 2021
9 tasks
hasbro17 pushed a commit to hasbro17/etcd that referenced this pull request Feb 2, 2022
@mitake mitake mentioned this pull request Apr 29, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants