Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] enhance health check endpoint to support serializable request #13706

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Feb 17, 2022

Backport the PR 13399 to 3.5.

cc @serathius @spzala @hexfusion @ptabor

@ahrtr ahrtr force-pushed the 3.5-serializable_health_check branch from 8b9cefc to 7db1051 Compare February 17, 2022 07:03
@ahrtr ahrtr changed the title enhance health check endpoint to support serializable request [3.5] enhance health check endpoint to support serializable request Feb 17, 2022
@serathius
Copy link
Member

Not sure about backporting features, would want to wait for @spzala opinion.

@ahrtr
Copy link
Member Author

ahrtr commented Feb 18, 2022

Not sure about backporting features, would want to wait for @spzala opinion.

Actually we can regard it as a bug, because etcd doesn't process health check properly.

@ptabor
Copy link
Contributor

ptabor commented Feb 21, 2022

I think cherry picking is OK from pragmatic perspective for low/risk / absolutely no behavioural changes,
taking in consideration the complexity of major etcd version upgrade.

Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@moonovo
Copy link

moonovo commented Mar 29, 2022

@ahrtr please, how to use health check in k8s livenessProbe when client-cert-auth is enabled

@ahrtr
Copy link
Member Author

ahrtr commented Mar 29, 2022

@ahrtr please, how to use health check in k8s livenessProbe when client-cert-auth is enabled

health/serializable=true and set schema as HTTPS

@moonovo
Copy link

moonovo commented Mar 29, 2022

Thanks for your reply, when client-cert-auth enabled, etcd will verify client certificate. see listener.go#L483.
but the certificate cannot be configured for the k8s livenessProbe. There seems to be no way to use /health with client-cert-auth enabled.

@ahrtr
Copy link
Member Author

ahrtr commented Mar 29, 2022

Please have a try on 3.5.2 or the main branch, and let me know if you run into any issue.

@moonovo
Copy link

moonovo commented Mar 29, 2022

I opened an issue 13849.

@serathius
Copy link
Member

I think that's a goal of client-cert-auth to require client provide certificates :P
I don't think it's a bug, but a feature that might be worth implementing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants