-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] enhance health check endpoint to support serializable request #13706
[3.5] enhance health check endpoint to support serializable request #13706
Conversation
8b9cefc
to
7db1051
Compare
Not sure about backporting features, would want to wait for @spzala opinion. |
Actually we can regard it as a bug, because etcd doesn't process health check properly. |
I think cherry picking is OK from pragmatic perspective for low/risk / absolutely no behavioural changes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
@ahrtr please, how to use health check in k8s livenessProbe when client-cert-auth is enabled |
|
Thanks for your reply, when |
Please have a try on 3.5.2 or the main branch, and let me know if you run into any issue. |
I opened an issue 13849. |
I think that's a goal of |
Backport the PR 13399 to 3.5.
cc @serathius @spzala @hexfusion @ptabor