Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog for 3.5.4 and 3.6 #13970

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Update changelog for 3.5.4 and 3.6 #13970

merged 1 commit into from
Apr 23, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 21, 2022

@ahrtr ahrtr mentioned this pull request Apr 21, 2022
Closed
6 tasks
@ahrtr
Copy link
Member Author

ahrtr commented Apr 21, 2022 •
edited
Loading

@serathius I recall that you proposed to link to issue instead of PR in CHANGELOG. I'd like to keep linking to PR for now, reasons:

  1. Different releases will have different links (PRs). If linking issue, then they will link to the same one.
  2. Basically all existing CHANGELOG Items are linking to PR, so keep consistent with the existing behavior.

If you still propose to link to issue, could you raise a PR to update the contributor guide, and get approved & merged firstly?

spzala
spzala approved these changes Apr 23, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @ahrtr
PR has links to issue.

@spzala spzala merged commit 6205f1a into etcd-io:main Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptabor ptabor ptabor approved these changes

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrtr @spzala @ptabor