wal: removes entry size limit #14057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
May 21, 2022
| zeroMb := 0 | ||
| oneMb := 1 * 1024 * 1024 | ||
| twentyMb := 20 * 1024 * 1024 | ||
| for _, entrySize := range []int{zeroMb, oneMb, twentyMb} { |
There was a problem hiding this comment.
Please use subtest instead. There are lots of examples, such as discovery_test.go#L66
ahrtr
requested changes
May 21, 2022
| zeroMb := 0 | ||
| oneMb := 1 * 1024 * 1024 | ||
| twentyMb := 20 * 1024 * 1024 | ||
| for _, entrySize := range []int{zeroMb, oneMb, twentyMb} { |
|
Overall looks good to me. Please fix the comments and see issuecomment-1133780272 |
ptabor
reviewed
May 22, 2022
| @@ -84,10 +79,6 @@ func (d *decoder) decodeRecord(rec *walpb.Record) error { | |||
| } | |||
|
|
|||
| recBytes, padBytes := decodeFrameSize(l) | |||
| if recBytes >= maxWALEntrySizeLimit-padBytes { | |||
There was a problem hiding this comment.
I think it was defensive protection against OOMing or consuming whole server memory in case of a corrupted frame.
I agree with @ahrtr suggestion from: #14025 (comment) to use:
etcd/server/storage/wal/wal.go
Line 55 in 8093fc9
And refuse configs where --max-request-bytes > SegmentSizeBytes/4=16MB
|
I think it got obsolete by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #14025
I don't fully get the reason the entry size limit was introduced.
I have added tests that show that the entry size that is currently set as maximum can be exceeded, without compromising the wal functionalities.