Checking cluster member count in watch_test #14285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test should fail early on an insufficient cluster instead of panicking during the test. Fixes issue etcd-io#14259. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
lavacat
reviewed
Jul 30, 2022
| @@ -50,6 +50,10 @@ func runWatchTest(t *testing.T, f watcherTest) { | |||
| clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3}) | |||
| defer clus.Terminate(t) | |||
|
|
|||
| if len(clus.Members) != 3 { | |||
There was a problem hiding this comment.
I've tried stepping through this test and there is check here
that waits for all members to be up. I think it checks for size implicitly.
Do we really need this extra check?
There was a problem hiding this comment.
Right, I don't think we should add the additional check either, unless you can provide a reasonable case in which the len(clus.Members) != 3 is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test should fail early on an insufficient cluster instead of
panicking during the test.
Fixes issue #14259.
Signed-off-by: Thomas Jungblut tjungblu@redhat.com