Tests: Check Watch response error not nil to avoid runtime panic. #14591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halegreen
changed the title
Codecov Report
@@ Coverage Diff @@
## main #14591 +/- ##
==========================================
- Coverage 75.66% 75.46% -0.21%
==========================================
Files 457 457
Lines 37290 37213 -77
==========================================
- Hits 28215 28082 -133
- Misses 7314 7361 +47
- Partials 1761 1770 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ZoeShaw101 The change looks good to me. Please signoff the commit. |
Fixes issue: etcd-io#14259 Signed-off-by: 王霄霄 <1141195807@qq.com>
|
@ahrtr Thanks! signoff the commit done. |
ahrtr
approved these changes
Oct 16, 2022
halegreen
added a commit
to halegreen/etcd
that referenced
this pull request
Oct 16, 2022
Signed-off-by: 王霄霄 <1141195807@qq.com>
halegreen
added a commit
to halegreen/etcd
that referenced
this pull request
Oct 16, 2022
Signed-off-by: 王霄霄 1141195807@qq.com
|
@ahrtr backport this PR to both 3.5 and 3.4 is done, pls check , thanks ~ |
halegreen
added a commit
to halegreen/etcd
that referenced
this pull request
Oct 16, 2022
Signed-off-by: 王霄霄 1141195807@qq.com Signed-off-by: 王霄霄 <1141195807@qq.com>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Jul 26, 2023
Signed-off-by: 王霄霄 <1141195807@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check Watch response error not nil to avoid test suite runtime panic.
Fixes issue: #14259
Signed-off-by: Wang Xiaoxiao 1141195807@qq.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.