Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] server: refresh auth info when etcd recovers from a snapshot #14648

Merged
merged 2 commits into from
Oct 29, 2022
Merged

[3.5] server: refresh auth info when etcd recovers from a snapshot #14648

merged 2 commits into from
Oct 29, 2022

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Oct 29, 2022

@mitake
server: add a unit test case for authStore.Reocver() with empty range…
efb9480 
…PermCache

Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake mitake mentioned this pull request Oct 29, 2022
Merged
@ahrtr
Copy link
Member

ahrtr commented Oct 29, 2022

The unit failed as expected because the PR #14574 hasn't been backported to 3.5 yet. I would suggest you backport the to 3.5 in this PR as well. We can just backport the one line code change for now, and ignore e2e test for now.

@ahrtr ahrtr mentioned this pull request Oct 29, 2022
Merged
@mitake
etcdserver: call refreshRangePermCache on Recover() in AuthStore. etc…
1e96e0b 
…d-io#14574

Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
@mitake
Copy link
Contributor Author

mitake commented Oct 29, 2022

@veshij Can I backport your fix to this PR? We have a unit test to verify the behavior so can work on e2e test later.

ahrtr
ahrtr approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @mitake

@veshij
Copy link
Contributor

veshij commented Oct 29, 2022

@veshij Can I backport your fix to this PR? We have a unit test to verify the behavior so can work on e2e test later.

Sure!

@mitake
Copy link
Contributor Author

mitake commented Oct 29, 2022

Thanks @veshij !

@ahrtr ahrtr changed the title [3.5] server: add a unit test case for authStore.Reocver() with empty rangePermCache [3.5] server: refresh auth info when etcd recovers from a snapshot Oct 29, 2022
@ahrtr
Copy link
Member

ahrtr commented Oct 29, 2022

Also partially backport #14574

@ahrtr ahrtr merged commit 17cb291 into etcd-io:release-3.5 Oct 29, 2022
@mitake mitake deleted the test-authrecover-3.5 branch October 29, 2022 10:15
@serathius serathius mentioned this pull request Nov 14, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
stage/merge-when-tests-green
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitake @ahrtr @veshij