tests: fix anti-pattern name in NewEtcdProcessCluster
#14825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clark <fwyongxing@gmail.com>
fuweid
reviewed
Nov 23, 2022
| ForceNewCluster bool | ||
| InitialToken string | ||
| QuotaBackendBytes int64 | ||
| DisableStrictReconfigCheck bool |
There was a problem hiding this comment.
No sure we should change it.
Both Disable or No seems to enable it by default. If we switch to CN, I think we should change all the places to DefaultXXXConfig, like DefaultConfig. What do you think?
There was a problem hiding this comment.
Looks like DefaultConfig was updated. As this is just an internal test framework I don't see any negative impacts of changing the defaults.
There was a problem hiding this comment.
My bad. The WithConfigXYZ always call DefaultConfig. For sure, it looks good.
There was a problem hiding this comment.
Thanks for taking the time to review, I should have explained it earlier😬
serathius
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #14711
Rename anti-pattern-naming fields(DisableStrictReconfigCheck and NoCN) and move them to DefaultConfig.