Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/common: migrate auth tests #1 #14998

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Conversation

chaochn47
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #14998 (008df94) into main (ee9db72) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14998      +/-   ##
==========================================
- Coverage   74.65%   74.59%   -0.07%     
==========================================
  Files         415      415              
  Lines       34338    34267      -71     
==========================================
- Hits        25636    25560      -76     
- Misses       7062     7070       +8     
+ Partials     1640     1637       -3     
Flag Coverage Δ
all 74.59% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/proxy/grpcproxy/register.go 50.00% <0.00%> (-19.77%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
server/storage/mvcc/watchable_store.go 84.78% <0.00%> (-5.44%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0.00%> (-3.48%) ⬇️
server/etcdserver/raft.go 88.63% <0.00%> (-2.28%) ⬇️
pkg/schedule/schedule.go 80.45% <0.00%> (-1.15%) ⬇️
server/etcdserver/api/v3rpc/watch.go 86.66% <0.00%> (-0.96%) ⬇️
server/etcdserver/v3_server.go 78.18% <0.00%> (-0.88%) ⬇️
pkg/proxy/server.go 60.67% <0.00%> (-0.34%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 requested review from ahrtr and ptabor and removed request for ahrtr and ptabor December 16, 2022 18:55
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @chaochn47

@ahrtr ahrtr merged commit 614e520 into etcd-io:main Dec 17, 2022
@chaochn47 chaochn47 deleted the auth_test_split branch December 19, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants