./scripts/fix.sh: Takes care of goimports across the whole project. #15052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Tabor <ptab@google.com>
ptabor
force-pushed
the
20221228-goimports-fix
branch
from
7fa5b85 to
9317b5a
Compare
ahrtr
reviewed
Dec 28, 2022
| "go.etcd.io/etcd/api/v3/etcdserverpb" | ||
| pb "go.etcd.io/etcd/api/v3/etcdserverpb" | ||
| "go.etcd.io/etcd/client/pkg/v3/types" | ||
| "go.etcd.io/etcd/server/v3/auth" | ||
| "go.etcd.io/etcd/server/v3/config" | ||
| "go.etcd.io/raft/v3" | ||
| "go.uber.org/zap" |
There was a problem hiding this comment.
I am curious why such kind of import disorder isn't discovered by
Line 33 in a4c1b3a
There was a problem hiding this comment.
Thank you @demoManito . Please feel free to deliver a PR to fix it if you have any findings.
Codecov Report
@@ Coverage Diff @@
## main #15052 +/- ##
==========================================
+ Coverage 74.75% 74.92% +0.17%
==========================================
Files 415 415
Lines 34273 34276 +3
==========================================
+ Hits 25620 25682 +62
+ Misses 7012 6970 -42
+ Partials 1641 1624 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Piotr Tabor <ptab@google.com>
ptabor
force-pushed
the
20221228-goimports-fix
branch
from
9317b5a to
9e1abba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.