Add linearizability nightlies for release 3.4/3.5 #15106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
linearizability-nightly-release
branch
10 times, most recently
from
ad96b83
to
52dbc69
Compare
Codecov Report
@@ Coverage Diff @@
## main #15106 +/- ##
==========================================
- Coverage 74.68% 74.54% -0.15%
==========================================
Files 415 415
Lines 34341 34341
==========================================
- Hits 25649 25599 -50
- Misses 7054 7101 +47
- Partials 1638 1641 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
reviewed
Jan 16, 2023
Comment on lines
+37
to
+41
| *) | ||
| make gofail-enable | ||
| make build | ||
| ;; |
There was a problem hiding this comment.
Suggested change
| *) | |
| make gofail-enable | |
| make build | |
| ;; | |
| main) | |
| make gofail-enable | |
| make build | |
| ./bin/etcd --version | |
| ;; | |
| *) | |
| echo "Invalid GITHUB_REF: ${GITHUB_REF}" | |
| exit 1 | |
| ;; |
There was a problem hiding this comment.
That's not correct because on PR we get GITHUB_REF=refs/pull/<pr_number>/merge
ahrtr
approved these changes
Jan 16, 2023
This CL refactors the tests to reuse a single workflow that has parameters. This is then reused for PRs/pushes and the nightlies. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com> Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
linearizability-nightly-release
branch
from
52dbc69
to
ab3c530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr @ptabor @tjungblu