CHANGELOG: add 'server/embed: fix data race when starting both secure & insecure gRPC servers on the same address' into 3.4/3.5 #15546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
changed the title
fuweid
changed the title
ahrtr
reviewed
Mar 22, 2023
CHANGELOG/CHANGELOG-3.4.md
Outdated
| @@ -6,6 +6,9 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
|
|
|||
| ## v3.4.25 (TBD) | |||
|
|
|||
| ### etcd server | |||
| - Fix [server/embed: fix data race when start insecure grpc](https://github.com/etcd-io/etcd/pull/15518) | |||
There was a problem hiding this comment.
Minor comment to make it clearer.
Suggested change
| - Fix [server/embed: fix data race when start insecure grpc](https://github.com/etcd-io/etcd/pull/15518) | |
| - Fix [server/embed: fix data race when starting both secure & insecure gRPC servers on the same address](https://github.com/etcd-io/etcd/pull/15518) |
CHANGELOG/CHANGELOG-3.5.md
Outdated
| @@ -6,6 +6,9 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
|
|
|||
| ## v3.5.8 (TBD) | |||
|
|
|||
| ### etcd server | |||
| - Fix [server/embed: fix data race when start insecure grpc](https://github.com/etcd-io/etcd/pull/15517) | |||
Add item [server/embed: fix data race when starting both secure & insecure gRPC servers on the same address] to 3.4/3.5 changelog. REF: etcd-io#15509 Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
update-changelog
branch
from
ad90d2d to
0daf06f
Compare
fuweid
changed the title
ahrtr
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add item server/embed: fix data race when starting both secure & insecure gRPC servers on the same address to 3.4/3.5 changelog.
REF: #15509
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.