Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdutl: fix db double closed #16120

Merged
merged 1 commit into from
Jul 6, 2023
Merged

etcdutl: fix db double closed #16120

merged 1 commit into from
Jul 6, 2023

Conversation

Tachone
Copy link
Contributor

@Tachone Tachone commented Jun 21, 2023 •
edited
Loading

#11838 fix db may not be closed，but in 768da4 missing line: dbClosed = true（git bisect is very useful ）

if copyAndVerifyDB return nil, db is closed twice.

@Tachone Tachone marked this pull request as ready for review June 25, 2023 06:59
@Tachone
etcdutl: fix db double closed
7bd77c2 
Signed-off-by: shitao.lst <acm_tach@163.com>
@Tachone Tachone force-pushed the shitao.lst/fix_db_close branch from 80f16e5 to 7bd77c2 Compare June 28, 2023 03:52
ahrtr
ahrtr approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Tachone

@ahrtr
Copy link
Member

ahrtr commented Jul 6, 2023

@Tachone could you backport this PR to 3.5?

@ahrtr ahrtr merged commit 4364e75 into etcd-io:main Jul 6, 2023
@Tachone Tachone mentioned this pull request Jul 10, 2023
Merged
@Tachone
Copy link
Contributor Author

Tachone commented Jul 10, 2023

@Tachone could you backport this PR to 3.5?

Sure. #16201

@serathius serathius mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaochn47 chaochn47 chaochn47 approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
backport/v3.5
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tachone @ahrtr @chaochn47