Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Backport #13577 to 3.5 #16241

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[3.5] Backport #13577 to 3.5 #16241

merged 1 commit into from
Jul 14, 2023

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jul 14, 2023 •
edited
Loading

Backport #13577
Disable auth gracefully without impacting existing watchers.

Related:

TODO: changelog for 3.5 after this pr is merged.

@liangyuanpeng
Backport etcd-io#13577
960cd26 
Disable auth gracefully without impacting existing watchers.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Jul 14, 2023

Please also add two changelog items for both 3.5 and 3.4,

  • For etcdserver: "Skip getting authInfo from incoming context when auth is disabled"
  • For clientv3: "Reset auth token when failing to authenticate due to auth being disabled"

jmhbnz
jmhbnz approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @liangyuanpeng 🙏🏻

fuweid
fuweid approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr
Copy link
Member

ahrtr commented Jul 14, 2023

IT's a backporting & simple & straightforward change, merging ....

@ahrtr ahrtr merged commit 9ac1d73 into etcd-io:release-3.5 Jul 14, 2023
@ahrtr ahrtr mentioned this pull request Jul 14, 2023
Closed
4 tasks
@liangyuanpeng liangyuanpeng deleted the backport_13577_3.5 branch July 19, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liangyuanpeng @ahrtr @fuweid @jmhbnz