-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version to 1.21.5 #17073
Update go version to 1.21.5 #17073
Conversation
Hi @jonasrdl. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module go.etcd.io/etcd/v3 | |||
|
|||
go 1.21 | |||
go 1.21.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a version file for this now, looking into the previous bump:
cc130fd#diff-69c69535f549f1e70ce037415e46a2894f04d4147c7929de6ef1db8f72a0a136
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, thanks for the hint, I pushed a fix
could you also squash your commits into one please? don't know if we have Tide enabled, but it doesn't seem like we have a squash label available. |
other than that, LGTM (non-binding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @jonasrdl
Edit: And I just noticed this is your first pull request, welcome! 🎉
Signed-off-by: Jonas Riedel <jonasriedel@pm.me> Signed-off-by: Jonas Riedel <jonasriedel@pm.me> Signed-off-by: Jonas Riedel <jonasriedel@pm.me>
241bdf5
to
5cd2887
Compare
Updates go version to 1.21.5
#17049.