Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.21.5 #17073

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

jonasrdl
Copy link
Contributor

@jonasrdl jonasrdl commented Dec 6, 2023

Updates go version to 1.21.5

#17049.

@k8s-ci-robot
Copy link

Hi @jonasrdl. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jonasrdl jonasrdl marked this pull request as ready for review December 6, 2023 15:04
@jonasrdl jonasrdl changed the title etcd: Update go version to 1.21.5 Update go version to 1.21.5 Dec 6, 2023
@tjungblu
Copy link
Contributor

tjungblu commented Dec 6, 2023

/ok-to-test

go.mod Outdated
@@ -1,6 +1,6 @@
module go.etcd.io/etcd/v3

go 1.21
go 1.21.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a version file for this now, looking into the previous bump:
cc130fd#diff-69c69535f549f1e70ce037415e46a2894f04d4147c7929de6ef1db8f72a0a136

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks for the hint, I pushed a fix

@tjungblu
Copy link
Contributor

tjungblu commented Dec 6, 2023

could you also squash your commits into one please? don't know if we have Tide enabled, but it doesn't seem like we have a squash label available.

@tjungblu
Copy link
Contributor

tjungblu commented Dec 6, 2023

other than that, LGTM (non-binding)

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @jonasrdl

Edit: And I just noticed this is your first pull request, welcome! 🎉

Signed-off-by: Jonas Riedel <jonasriedel@pm.me>

Signed-off-by: Jonas Riedel <jonasriedel@pm.me>

Signed-off-by: Jonas Riedel <jonasriedel@pm.me>
@jonasrdl jonasrdl force-pushed the update-to-go-1.21.5 branch from 241bdf5 to 5cd2887 Compare December 6, 2023 18:25
@ahrtr ahrtr merged commit 7851295 into etcd-io:main Dec 6, 2023
36 checks passed
@jonasrdl jonasrdl deleted the update-to-go-1.21.5 branch December 6, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants