Fix tx buffer inconsistency if there are duplicate keys in one tx. #17228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siyuan Zhang <sizhang@google.com>
…bucket. Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
txBuf1
branch
from
00d3432 to
971a4f5
Compare
|
/retest |
|
cc @serathius @ahrtr |
serathius
approved these changes
Jan 12, 2024
ahrtr
approved these changes
Jan 12, 2024
Please read #17234 |
|
High chance this PR caused #17247 |
4 tasks
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Jan 19, 2024
Actually pull/17228 was fixing a non-exist issue, because there will never have duplicated items. Please refer to etcd-io#17247 (comment). The PR also introduces a bug (issues/17247). Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Merged
ahrtr
added a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
related to #17158