Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CreateBucket with CreateBucketIfNotExists #17249

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 15, 2024

Fix #17245

etcd creates the meta bucket twice on startup,

Overall, it isn't a big problem. But let's replace CreateBucket with CreateBucketIfNotExists to remove the error message, to avoid any confusion.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@serathius
Copy link
Member

There is one optional followup. Etcd should not write error logs during normal function. We could add a e2e test that confirms that.

@ahrtr
Copy link
Member Author

ahrtr commented Jan 16, 2024

There is one optional followup. Etcd should not write error logs during normal function. We could add a e2e test that confirms that.

Agreed that it's nice to have.

@ahrtr ahrtr merged commit e3c70c8 into etcd-io:main Jan 16, 2024
40 checks passed
@ahrtr ahrtr deleted the meta_bucket_20240115 branch June 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Etcd extentensivly logging error "bucket already exists"
3 participants