[3.5] backport support dynamically adding & starting new member #17437
Conversation
|
Hi @YaoC. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/cc @ahrtr @serathius |
Rebased this PR. There is no response from the original author, so Benjamin (ahrtr@) continue to work on this PR. Signed-off-by: Vitalii Levitskii <vitalii@uber.com> Signed-off-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: YaoC <chengyao09@hotmail.com>
…w member Signed-off-by: Benjamin Wang <wachao@vmware.com> Signed-off-by: YaoC <chengyao09@hotmail.com>
Signed-off-by: YaoC <chengyao09@hotmail.com>
YaoC
force-pushed
the
backport-14589-to-release-3.5
branch
from
26380a9
to
50c26f5
Compare
|
/retest |
|
I am a little confused, the comment #17123 (comment) is suggesting to backport #16707, but this PR is backporting #14589. What did I miss? |
Backport #16707 may not work here, since func values does not return the flag |
| From: peerAdvertiseUrl, | ||
| } | ||
| } | ||
| func (cfg *EtcdServerProcessConfig) SetInitialCluster(nodes []string, initialClusterState string) { |
There was a problem hiding this comment.
The implementation seems to be different from the main branch. There is no SetInitialCluster. Instead it's SetInitialOrDiscovery.
Also the implementation of EtcdServerProcessConfig is also a little different from the main branch.
There was a problem hiding this comment.
My understanding is that the PR #14589 is to extract the part originally in the for-loop as a new method EtcdServerProcessConfig . Then, using this method, we can create a config and dynamically add new members to the cluster. As for the implementation itself, it needs to backport some other PRs to align.
SetInitialOrDiscovery is also the same reason, discovery was introduced by a530745, so I removed discovery from the method.
I can pause this PR first and align the content of EtcdServerProcessConfig and discovery. What do you think?
There was a problem hiding this comment.
I can pause this PR first
OK
align the content of
EtcdServerProcessConfiganddiscovery.
Not fully understood your point. but happy to have more discuss under your new PR.
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@YaoC: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Backport of PR #14589
Align the
patchArgsmethod with that in the main branch since theinitial-cluster-stateflag is added as a default argument. #17123 (comment)Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.