Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Added client keepalive arguments to the grpc-proxy #17447

Conversation

halleyshx
Copy link
Contributor

…m arguments to the grpc-proxy

Signed-off-by: shihuixing <shihuixing@jd.com>
@k8s-ci-robot
Copy link

Hi @halleyshx. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahrtr ahrtr changed the title Added client keepalive arguments to the grpc-proxy for 3.5 [3.5] Added client keepalive arguments to the grpc-proxy Feb 18, 2024
@ahrtr
Copy link
Member

ahrtr commented Feb 18, 2024

/ok-to-test

halleyshx pushed a commit to halleyshx/etcd that referenced this pull request Feb 19, 2024
Signed-off-by: shihuixing <shihuixing@jd.com>
halleyshx pushed a commit to halleyshx/etcd that referenced this pull request Feb 19, 2024
Signed-off-by: shihuixing <shihuixing@jd.com>
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 9b9c049 into etcd-io:release-3.5 Feb 20, 2024
15 checks passed
halleyshx pushed a commit to halleyshx/etcd that referenced this pull request Feb 22, 2024
Signed-off-by: shihuixing <shihuixing@jd.com>
halleyshx pushed a commit to halleyshx/etcd that referenced this pull request Feb 26, 2024
Signed-off-by: shihuixing <shihuixing@jd.com>
ahrtr added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants