Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] backport etcdutl memory allocation issue #17977

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented May 10, 2024

ivanvc and others added 2 commits May 9, 2024 21:41
Accept a third argument for NewDefaultBackend for overrides to the
BackendConfig.
Add a new function, WithMmapSize, which modifies the backend config to
provide a custom InitiamMmapSize.

Backports commit: d69adf4 / PR: etcd-io#17277

Signed-off-by: Ivan Valdes <ivan@vald.es>
When running the snapshot command, allow receiving an initial memory map
allocation for the database, avoiding future memory allocation issues.

Backports commit: be28833 / PR: etcd-io#17277

Co-authored-by: Fatih USTA <fatihusta86@gmail.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented May 10, 2024

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please also update 3.5 changelog, thx

@serathius serathius merged commit 8f6d2dc into etcd-io:release-3.5 May 10, 2024
23 checks passed
@ivanvc ivanvc deleted the release-3.5-backport-etcdutl-memory-allocation-issue branch May 10, 2024 09:56
ivanvc added a commit to ivanvc/etcd that referenced this pull request May 10, 2024
Signed-off-by: Ivan Valdes <ivan@vald.es>
ahrtr added a commit that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants