Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Differentiate the warning message for rejected client and peer connections #18319

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jul 14, 2024

…tions

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit e940b8e into etcd-io:release-3.5 Jul 14, 2024
25 checks passed
@ahrtr ahrtr deleted the 3.5_log_20240714 branch July 14, 2024 10:04
@ivanvc ivanvc mentioned this pull request Jul 15, 2024
4 tasks
@ivanvc
Copy link
Member

ivanvc commented Jul 15, 2024

@ahrtr, do we want a change log entry for this backport? It sounds user-facing, so I thought we did.

@ahrtr
Copy link
Member Author

ahrtr commented Jul 15, 2024

@ahrtr, do we want a change log entry for this backport? It sounds user-facing, so I thought we did.

Already done. #18320

@ivanvc
Copy link
Member

ivanvc commented Jul 15, 2024

Already done. #18320

Duh, yeah, my bad 😃, I didn't see it.

aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
[3.5] Differentiate the warning message for rejected client and peer connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants