Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase raftAfterSave to 3 seconds #18390

Closed
wants to merge 1 commit into from
Closed

Increase raftAfterSave to 3 seconds #18390

wants to merge 1 commit into from

Conversation

henrybear327
Copy link
Contributor

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrybear327
Increase raftAfterSave to 3 seconds
33058a0 
Reference:
- etcd-io#18240

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 force-pushed the fix/raftAfterSave_sleep branch from d40c3b1 to 33058a0 Compare August 1, 2024 18:21
@serathius
Copy link
Member

How did you test it? This increases the time failpoint is active, not the request timeout. Is this really fixing the issue?

@henrybear327
Copy link
Contributor Author

How did you test it? This increases the time failpoint is active, not the request timeout. Is this really fixing the issue?

Oops I misread the requirement of increasing the client timeout instead of the failpoint time. Sorry about this. I will make the change accordingly ...

@henrybear327 henrybear327 marked this pull request as draft August 1, 2024 19:27
@henrybear327
Copy link
Contributor Author

With #18393, I guess we will not need to increase the client timeout in the meantime right @serathius?

@henrybear327 henrybear327 deleted the fix/raftAfterSave_sleep branch August 2, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/robustness-testing area/testing do-not-merge/work-in-progress size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrybear327 @k8s-ci-robot @serathius