Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use testify instead of t.Fatal or t.Error in server package (part 1) #18971

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 30, 2024

Description

This uses testify instead of testing for t.Fatal or t.Error calls in server package

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (ebb2b06) to head (c3fb795).
Report is 166 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18971   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         420      420           
  Lines       35641    35641           
=======================================
  Hits        24532    24532           
- Misses       9687     9691    +4     
+ Partials     1422     1418    -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb2b06...c3fb795. Read the comment docs.

@mmorel-35 mmorel-35 force-pushed the testifier/server branch 3 times, most recently from ea9e299 to 56d9dc3 Compare December 1, 2024 21:35
@ahrtr
Copy link
Member

ahrtr commented Dec 4, 2024

/ok-to-test

@mmorel-35 mmorel-35 force-pushed the testifier/server branch 3 times, most recently from bd41130 to c638757 Compare December 5, 2024 06:07
@mmorel-35
Copy link
Contributor Author

/test pull-etcd-verify

@mmorel-35 mmorel-35 force-pushed the testifier/server branch 2 times, most recently from 4ac9d68 to 68af9dd Compare December 12, 2024 06:21
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@ahrtr
Copy link
Member

ahrtr commented Jan 31, 2025

cc @ivanvc @jmhbnz @fuweid

@ahrtr
Copy link
Member

ahrtr commented Feb 3, 2025

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit d4173b2 into etcd-io:main Feb 3, 2025
34 checks passed
@mmorel-35 mmorel-35 deleted the testifier/server branch February 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants