Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse grpcOverheadBytes calculation by creating a function for that #18991

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

serathius
Copy link
Member

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (6fa7342) to head (c77ea65).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <100.00%> (+0.47%) ⬆️
server/etcdserver/api/v3rpc/grpc.go 100.00% <100.00%> (ø)
server/etcdserver/api/v3rpc/watch.go 84.06% <100.00%> (+1.25%) ⬆️

... and 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18991      +/-   ##
==========================================
+ Coverage   68.53%   68.74%   +0.21%     
==========================================
  Files         420      420              
  Lines       35619    35621       +2     
==========================================
+ Hits        24410    24489      +79     
+ Misses       9777     9702      -75     
+ Partials     1432     1430       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa7342...c77ea65. Read the comment docs.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 06c0736 into etcd-io:main Dec 2, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants