-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a v2 snapshot when running etcdutl migrate command #19168
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
250f708
to
d8f3b56
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 26 files with indirect coverage changes @@ Coverage Diff @@
## main #19168 +/- ##
==========================================
- Coverage 68.83% 68.73% -0.10%
==========================================
Files 420 420
Lines 35641 35703 +62
==========================================
+ Hits 24535 24542 +7
- Misses 9680 9745 +65
+ Partials 1426 1416 -10 Continue to review full report in Codecov by Sentry.
|
d8f3b56
to
033f4cf
Compare
d71fc9f
to
f59e8b8
Compare
This is a huge PR, let me breakdown it into small PRs to make the review easier. |
43a213e
to
acffdb5
Compare
acffdb5
to
174c8b4
Compare
Also added test to cover the etcdutl migrate command Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
So many codecov warnings, is there any way to hide them? |
174c8b4
to
df49a51
Compare
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Refer to #17911 (comment)
This PR will make the
etcdutl migrate
command fully functional.It creates a v2snapshot from the v3store.
You will never see error below anymore when executing
etcdutl migrate
command,After executing the migrate command for all members, you just need to directly replace the binary of each member, then all done for the offline downgrade. Of course, it's still recommended to follow/perform the online downgrade process, as it doesn't break the workload. cc @ivanvc @jmhbnz
It also adds a separate
etcdutl v2snapshot create
commandIt's just a manual last to resort solution for any potential issue. Usually we don't need it.
I need to add e2e test. I may also break down it into smaller PRs.