Mark etcd-local-tester as deprecated so we can remove it in future #19297
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Blair <mail@jamesblair.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 30 files with indirect coverage changes @@ Coverage Diff @@
## main #19297 +/- ##
==========================================
+ Coverage 68.84% 68.88% +0.04%
==========================================
Files 420 420
Lines 35689 35689
==========================================
+ Hits 24570 24585 +15
+ Misses 9693 9688 -5
+ Partials 1426 1416 -10 Continue to review full report in Codecov by Sentry.
|
serathius
approved these changes
Jan 29, 2025
ahrtr
approved these changes
Jan 29, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at something else in our
tools/directory the other day I stumbled into thelocal-testerdirectory and taking a brief look it seemed to me like it was something we no longer used as we have the massively more comprehensive robustness testing suite now. The last meaningful update to the tool looked to be about eight years ago.I propose we mark this old utility as deprecated and remove it in future so we don't confuse anyone with what tool they should be using to validate etcd behaviour under failure conditions.
cc @serathius, @ahrtr