integration: make clusterMustProgress retry on lost leader #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
|
I could somewhat reliably reproduce the failure (~10%) by using 11 nodes on a spinning disk and this seems to fix it even with several elections. /cc @AkihiroSuda |
|
Discussed this a bit with @xiang90. It seems semaphore is seeing this problem because it's not setting ETCD_ELECTION_TIMEOUT_TICKS like travis. I tried to repro with the election ticks set to 600 and the test seems to work OK. |
|
So probably just add this env into semaphore as well? |
|
@xiang90 added |
|
@heyitsanthony OK. let's close this one and #5022? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5022