Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: fix race on watch initial revision #6587

Merged
merged 1 commit into from
Oct 5, 2016
Merged

clientv3: fix race on watch initial revision #6587

merged 1 commit into from
Oct 5, 2016

Commits on Oct 5, 2016

  1. clientv3: fix race on watch initial revision 

    The initial revision was being updated in the substream goroutine defer;
this was racing with the resume path fetching the initial revision when
the substream closes during resume. Instead, update the initial revision
whenever the substream processes a new watch response. Since the substream
cannot receive a watch response while it is resuming, the write to the
initial revision is ordered to always happen after the resume read.

Fixes etcd-io#6586
    Anthony Romano committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    06d5cf2 View commit details
    Browse the repository at this point in the history