auth: unit-test for authStore.AuthDisable() #7257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Feb 1, 2017
auth/store_test.go
Outdated
| t.Errorf("expected %v, got %v", ErrAuthNotEnabled, err) | ||
| } | ||
|
|
||
| // Disabling disabled auth again and trying to Authenticate |
There was a problem hiding this comment.
add a comment about why we want to try disabling auth again?
There was a problem hiding this comment.
Disabling disabled auth to make sure it can return safely if store is already disabled.
There was a problem hiding this comment.
@Rushit Yea. Probably add the comment into the code as a comment? I know why we need to test it. But it just reads strange without an explanation.
|
LGTM. Defer to @mitake |
This will cover unit-test for AuthDisable in store.go
ignore it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cover unit-test for AuthDisable in store.go
/cc @mitake @xiang90