-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: test expired certs in client #7824
Conversation
clientv3/integration/dial_test.go
Outdated
ClientCertAuth: true, | ||
} | ||
|
||
testTLSInfoBad = transport.TLSInfo{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testTLSInfoExpired
clientv3/integration/dial_test.go
Outdated
} | ||
|
||
testTLSInfoBad = transport.TLSInfo{ | ||
KeyFile: "../../integration/fixtures-bad/server-key.pem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixtures-expired
clientv3/integration/dial_test.go
Outdated
} | ||
|
||
// expect remote errors 'tls: bad certificate' | ||
_, err = integration.NewClientV3TLS(clus.Members[0], &testTLSInfoBad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to extend the integration package API:
_, err = clientv3.New(clientv3.Config{
Endpoints: []string{clus.Members[0].GRPCAddr()},
TLS: &testTLSInfoExpired,
})
clientv3/integration/dial_test.go
Outdated
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 1, PeerTLS: &testTLSInfo, ClientTLS: &testTLSInfo}) | ||
defer clus.Terminate(t) | ||
|
||
c1, err := integration.NewClientV3(clus.Members[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be left out? Seems like other tests should cover the success case already
Maybe change commit title from using the keyword
|
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@heyitsanthony @fanminshi All addressed. PTAL. Thanks. |
lgtm |
Trying to have some testing cases for #7784 and #7807.