Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: ensure CheckQuorum is enabled when readonlyoption is lease based #8567

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Sep 17, 2017

Fix #8450

The previous behavior is to return 0(invalid) index if CheckQuroum is not enabled but ReadOnlyOption is lease based.

This commit makes the checking explicitly during the initialization phase.

@xiang90
Copy link
Contributor Author

xiang90 commented Sep 17, 2017

/cc @javaforfun

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@085adc5). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8567   +/-   ##
=========================================
  Coverage          ?   75.55%           
=========================================
  Files             ?      356           
  Lines             ?    29152           
  Branches          ?        0           
=========================================
  Hits              ?    22027           
  Misses            ?     5567           
  Partials          ?     1558
Impacted Files Coverage Δ
raft/raft.go 92.29% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085adc5...9801fd7. Read the comment docs.

@lishuai87
Copy link
Contributor

LGTM

@xiang90 xiang90 merged commit a477708 into etcd-io:master Sep 18, 2017
@xiang90 xiang90 deleted the r_l branch September 18, 2017 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants