clientv3: add pinned() method to 'balancer' #8659
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially address #8660. |
xiang90
reviewed
Oct 6, 2017
clientv3/balancer.go
Outdated
| @@ -42,6 +42,7 @@ type balancer interface { | |||
|
|
|||
| endpoint(host string) string | |||
| endpoints() []string | |||
| pinned() string | |||
xiang90
reviewed
Oct 6, 2017
clientv3/retry.go
Outdated
| err := f(rpcCtx) | ||
| if err == nil { | ||
| return nil | ||
| } | ||
| if logger.V(4) { | ||
| logger.Infof("clientv3/retry: retry for error %v", err) | ||
| logger.Infof("clientv3/retry: retry for error %v (%s)", err, pinned) |
There was a problem hiding this comment.
retry on pined endpoint (%s) due to error %v
xiang90
reviewed
Oct 6, 2017
clientv3/retry.go
Outdated
| err := f(rpcCtx) | ||
| if err == nil { | ||
| return nil | ||
| } | ||
| if logger.V(4) { | ||
| logger.Infof("clientv3/auth-retry: retry for error %v", err) | ||
| logger.Infof("clientv3/auth-retry: retry for error %v (%s)", err, pinned) |
There was a problem hiding this comment.
retry on pined endpoint (%s) due to error %v
There was a problem hiding this comment.
@xiang90 That endpoint is errored, so it's unpinned by this line. So it's possible that we retry on different endpoint?
There was a problem hiding this comment.
or let's say ` error %s on pined endpoint (%s))
basically only (%s) is not descriptive.
|
this is just for debugging, right? |
|
@xiang90 Yes, this is for balancer debugging. But in the following PR, I will add gray-listing the timed out endpoint. |
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
|
@xiang90 PTAL. Fixed. Thanks. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.