Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Add server_version metric #8960

Merged
merged 1 commit into from
Dec 2, 2017
Merged

metrics: Add server_version metric #8960

merged 1 commit into from
Dec 2, 2017

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Dec 1, 2017

Fixes #8948

Example output:

curl -s http://localhost:2379/metrics  | grep etcd_server_version
# HELP etcd_server_version Which version is running. 1 for 'server_version' label with current version.
# TYPE etcd_server_version gauge
etcd_server_version{server_version="3.2.0+git"} 1

When the metric aggregated from multiple etcd nodes, can be used to monitor the # of nodes running each etcd version.

@gyuho
Copy link
Contributor

gyuho commented Dec 1, 2017

@jpbetz Simple e2e test case as https://github.com/coreos/etcd/blob/master/e2e/metrics_test.go would be great.

@xiang90
Copy link
Contributor

xiang90 commented Dec 1, 2017

/cc @brancz can you take a look?

@xiang90
Copy link
Contributor

xiang90 commented Dec 2, 2017

lgtm

gyuho
gyuho approved these changes Dec 2, 2017
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@xiang90 xiang90 merged commit 7e79c25 into etcd-io:master Dec 2, 2017
@brancz
Copy link
Contributor

brancz commented Dec 4, 2017

lgtm as well

@jpbetz jpbetz mentioned this pull request Dec 5, 2017
Closed
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 5, 2017

cc @mml

@wenjiaswe wenjiaswe mentioned this pull request Jun 13, 2018
Merged
gyuho added a commit that referenced this pull request Jun 13, 2018
@gyuho
Merge pull request #9845 from wenjiaswe/automated-cherry-pick-of-#896…
5e6adfa 
…0-upstream-release-3.2

Automated cherry pick of #8960
@wenjiaswe wenjiaswe mentioned this pull request Jun 13, 2018
Merged
gyuho added a commit that referenced this pull request Jun 13, 2018
@gyuho
Merge pull request #9848 from wenjiaswe/automated-cherry-pick-of-#896…
fab24fb 
…0-upstream-release-3.1

Automated cherry pick of #8960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpbetz @gyuho @xiang90 @brancz