Expose Raft Applied Index through to "etcdctl endpoint status" #9176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Jan 19, 2018
etcdctl/ctlv3/command/printer.go
Outdated
| @@ -20,7 +20,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| v3 "github.com/coreos/etcd/clientv3" | |||
| "github.com/dustin/go-humanize" | |||
| humanize "github.com/coreos/etcd/gopath/src/github.com/dustin/go-humanize" | |||
There was a problem hiding this comment.
Let's keep import path as it is? "github.com/dustin/go-humanize"
There was a problem hiding this comment.
That's odd. I didn't make that change. Will change it back.
UPDATE: looks like Visual Studio Code is doing that automatically when I save the file.
etcdserver/etcdserverpb/rpc.proto
Outdated
| @@ -907,6 +907,8 @@ message StatusResponse { | |||
| uint64 raftIndex = 5; | |||
| // raftTerm is the current raft term of the responding member. | |||
| uint64 raftTerm = 6; | |||
| // appliedIndex is the current raft applied index of the responding member. | |||
There was a problem hiding this comment.
s/appliedIndex/raftAppliedIndex/
|
LGTM after fixing the gofmt issue from CI |
Fixed based on feedback Fixed spacing Fix gofmt
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Raft Applied Index to be displayed "etcdctl endpoint status"
This addresses issue: #9123
Tested on a local cluster.