Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: improve Member TLS test coverage. #9184

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

hexfusion
Copy link
Contributor

Part of ongoing e2e coverage improvements.

ref: #9149

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-io
Copy link

Codecov Report

Merging #9184 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9184      +/-   ##
==========================================
- Coverage   76.18%   75.94%   -0.25%     
==========================================
  Files         359      359              
  Lines       30049    30049              
==========================================
- Hits        22894    22820      -74     
- Misses       5578     5642      +64     
- Partials     1577     1587      +10
Impacted Files Coverage Δ
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
pkg/adt/interval_tree.go 82.88% <0%> (-10.52%) ⬇️
etcdserver/api/v3rpc/lease.go 81.08% <0%> (-5.41%) ⬇️
etcdserver/corrupt.go 54.42% <0%> (-4.77%) ⬇️
etcdserver/api/v3rpc/watch.go 82.4% <0%> (-3.87%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
proxy/grpcproxy/watch.go 90.06% <0%> (-3.11%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
clientv3/leasing/cache.go 88.88% <0%> (-2.23%) ⬇️
rafthttp/msgappv2_codec.go 71.3% <0%> (-1.74%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9dc9c...61bc067. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @hexfusion !

@gyuho gyuho merged commit cdf7fcd into etcd-io:master Jan 22, 2018
@hexfusion hexfusion deleted the e2e-member branch January 22, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants