Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/flags: clean up, add "SelectiveStringsValue" #9457

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 19, 2018

To support #9216.

@gyuho gyuho force-pushed the fff branch 2 times, most recently from 2c3984f to 194815b Compare March 19, 2018 09:22
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #9457 into master will increase coverage by 0.38%.
The diff coverage is 85.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9457      +/-   ##
==========================================
+ Coverage   72.53%   72.91%   +0.38%     
==========================================
  Files         363      364       +1     
  Lines       30848    30874      +26     
==========================================
+ Hits        22376    22513     +137     
+ Misses       6852     6755      -97     
+ Partials     1620     1606      -14
Impacted Files Coverage Δ
pkg/flags/flag.go 88.67% <ø> (+3.38%) ⬆️
etcdmain/config.go 81.92% <100%> (ø) ⬆️
pkg/flags/ignored.go 100% <100%> (ø)
pkg/flags/urls.go 90% <100%> (+1.11%) ⬆️
pkg/flags/selective_string.go 80% <80%> (ø)
pkg/flags/strings.go 84.61% <84.61%> (-15.39%) ⬇️
pkg/tlsutil/tlsutil.go 86.2% <0%> (-6.9%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
proxy/grpcproxy/lease.go 80.54% <0%> (-4.08%) ⬇️
raft/raft.go 90.99% <0%> (-0.7%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10cf6b...1640cdb. Read the comment docs.

@gyuho gyuho merged commit 69eab45 into etcd-io:master Mar 19, 2018
@gyuho gyuho deleted the fff branch March 19, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants