Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: document deprecated ca-file flags (since v2.1) #9470

Merged
merged 12 commits into from
Mar 21, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 20, 2018

ca-file flags were deprecated in v2.1 (3 years ago).
Should be safe to deprecate.
Checked Kubernetes upstream not using these flags either.

Fix #9432.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Has been deprecated since 2.1...

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Has been deprecated since v2.1...

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho merged commit 5abbea8 into etcd-io:master Mar 21, 2018
@gyuho gyuho deleted the deprecated branch March 21, 2018 00:47
@codecov-io
Copy link

Codecov Report

Merging #9470 into master will increase coverage by 0.23%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9470      +/-   ##
=========================================
+ Coverage   72.47%   72.7%   +0.23%     
=========================================
  Files         364     364              
  Lines       30890   30883       -7     
=========================================
+ Hits        22389   22455      +66     
+ Misses       6872    6809      -63     
+ Partials     1629    1619      -10
Impacted Files Coverage Δ
etcdmain/config.go 81.71% <ø> (-0.21%) ⬇️
clientv3/yaml/config.go 86.66% <ø> (+5.41%) ⬆️
embed/config.go 60.71% <0%> (-0.14%) ⬇️
pkg/transport/listener.go 82.03% <100%> (-0.28%) ⬇️
etcdctl/ctlv3/command/global.go 60.6% <100%> (ø) ⬆️
etcdmain/grpc_proxy.go 63.42% <100%> (ø) ⬆️
etcdctl/ctlv3/ctl.go 100% <100%> (ø) ⬆️
etcdctl/ctlv2/command/util.go 44.57% <100%> (ø) ⬆️
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-16.67%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6153e9f...fa5f768. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants