Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: handle proposal error when processing internal raft request #9549

Merged
merged 2 commits into from
Apr 9, 2018

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 9, 2018

after #9137 merged, may need to handle the proposal error in etcdserver.

This will be used to fix issue: #8975

@xiang90
Copy link
Contributor

xiang90 commented Apr 9, 2018

lgtm. can you fix CI failure?

@gyuho
Copy link
Contributor

gyuho commented Apr 9, 2018

@nolouch Could you rebase from current master? Then, this should be able to pass CIs.

I just rebased. Merging in CI greens. Thanks!

@gyuho gyuho force-pushed the handle-fail branch 5 times, most recently from 1415e8d to b049faa Compare April 9, 2018 20:42
nolouch and others added 2 commits April 9, 2018 14:44
@gyuho
Copy link
Contributor

gyuho commented Apr 9, 2018

I've pushed another commit fixing a minor typo with changelog. All test suites passed including functional test https://semaphoreci.com/coreos/etcd/branches/pull-request-9549/builds/6. Merging.

Thanks.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@89c58b6). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9549   +/-   ##
=========================================
  Coverage          ?   72.27%           
=========================================
  Files             ?      368           
  Lines             ?    31339           
  Branches          ?        0           
=========================================
  Hits              ?    22649           
  Misses            ?     7041           
  Partials          ?     1649
Impacted Files Coverage Δ
etcdserver/v3_server.go 79.89% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c58b6...b049faa. Read the comment docs.

@gyuho gyuho merged commit eceacac into etcd-io:master Apr 9, 2018
@nolouch nolouch deleted the handle-fail branch October 29, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants