Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check: correct the memory limit #9806

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Check: correct the memory limit #9806

merged 1 commit into from
Jun 5, 2018

Conversation

spzala
Copy link
Member

@spzala spzala commented Jun 5, 2018

We should have limit of 3M not 30 as it's said in the doc comment.

We should be doing 3M not 30 as it's said in the doc comment.
@spzala spzala requested a review from gyuho June 5, 2018 13:52
@codecov-io
Copy link

Codecov Report

Merging #9806 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9806      +/-   ##
=========================================
+ Coverage   69.58%   69.6%   +0.01%     
=========================================
  Files         376     376              
  Lines       35229   35229              
=========================================
+ Hits        24514   24521       +7     
+ Misses       8954    8943      -11     
- Partials     1761    1765       +4
Impacted Files Coverage Δ
etcdctl/ctlv3/command/check.go 14% <ø> (ø) ⬆️
mvcc/watcher.go 96.29% <0%> (-3.71%) ⬇️
proxy/httpproxy/director.go 80% <0%> (-2.86%) ⬇️
raft/progress.go 94.17% <0%> (-1.95%) ⬇️
etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0%> (-1.74%) ⬇️
pkg/adt/interval_tree.go 87.08% <0%> (-1.51%) ⬇️
mvcc/watchable_store.go 82.8% <0%> (-1.41%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
etcdserver/apply.go 88.68% <0%> (-0.34%) ⬇️
etcdserver/server.go 73.05% <0%> (-0.08%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438e675...eff8166. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Jun 5, 2018

lgtm

@xiang90 xiang90 merged commit 94f2e45 into etcd-io:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants