Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer #9835

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Jun 12, 2018

#9822 fixed log entries starting with "etcdserver: request", but not those starting with. "etcdserver: read-only range request":

etcdserver: read-only range request "compare:<target:VALUE key:\"a\" value:\"1\" > success:<request_range:<key:\"/a\" range_end:\"/b\" > > failure:<request_range:<key:\"/a\" range_end:\"/b\" > > " with result "responses:<range_response_count:0> size:12" took too long (48.373µs) to execute

This fixes the logger to handle the "read-only range" warnings correctly:

etcdserver: read-only range request "compare:<target:VALUE key:\"a\" value_size:1 > success:<request_range:<key:\"/a\" range_end:\"/b\" > > failure:<request_range:<key:\"/a\" range_end:\"/b\" > >" with result "responses:<range_response_count:0> size:12" took too long (37.32µs) to execute

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants